Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TransitModel to TransitRepository #6148

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Rename TransitModel to TransitRepository #6148

merged 4 commits into from
Oct 16, 2024

Conversation

vpaturet
Copy link
Contributor

@vpaturet vpaturet commented Oct 11, 2024 •
edited
Loading

Summary

This PR renames the following objects:
TransitModel --> TimetableRepository
TransitModelIndex --> TimetableRepositoryIndex

The GraphQL field internalTransitModelTimeZone and the configuration parameter transitModelTimeZone are left unmodified in this PR.

Issue

No

Unit tests

No

Documentation

No

@vpaturet vpaturet self-assigned this Oct 11, 2024
@vpaturet vpaturet added Technical Debt bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR labels Oct 11, 2024
@vpaturet vpaturet changed the title Rename models to repository Rename models to repositories Oct 11, 2024
@vpaturet vpaturet marked this pull request as ready for review October 11, 2024 13:56
@vpaturet vpaturet requested a review from a team as a code owner October 11, 2024 13:57
@vpaturet vpaturet marked this pull request as draft October 11, 2024 13:57
@vpaturet vpaturet changed the title Rename models to repositories Rename TransitModel to TransitRepository Oct 11, 2024
@vpaturet vpaturet marked this pull request as ready for review October 11, 2024 13:58
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.83516% with 96 lines in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (3a216cb) to head (7571816).
Report is 9 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...planner/transit/service/DefaultTransitService.java 65.78% 26 Missing ⚠️
...rg/opentripplanner/graph_builder/GraphBuilder.java 0.00% 11 Missing ⚠️
...ner/standalone/configure/ConstructApplication.java 42.85% 7 Missing and 1 partial ⚠️
...ntripplanner/standalone/server/MetricsLogging.java 0.00% 6 Missing ⚠️
...planner/updater/configure/UpdaterConfigurator.java 14.28% 6 Missing ⚠️
...n/java/org/opentripplanner/standalone/OTPMain.java 0.00% 5 Missing ⚠️
...r/ext/transferanalyzer/DirectTransferAnalyzer.java 0.00% 3 Missing ⚠️
...planner/graph_builder/module/TripPatternNamer.java 0.00% 3 Missing ⚠️
..._builder/module/configure/GraphBuilderModules.java 0.00% 3 Missing ⚠️
...tortiles/layers/stations/StationsLayerBuilder.java 0.00% 2 Missing ⚠️
... and 18 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             dev-2.x    #6148   +/-   ##
==========================================
  Coverage      69.89%   69.90%           
  Complexity     17707    17707           
==========================================
  Files           1996     1996           
  Lines          75329    75334    +5     
  Branches        7713     7713           
==========================================
+ Hits           52654    52660    +6     
+ Misses         19998    19997    -1     
  Partials        2677     2677

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t2gran t2gran force-pushed the rename_repositories branch from bb1a3fd to 929b322 Compare October 11, 2024 16:11
@vpaturet
Merge branch 'dev-2.x' into rename_repositories
183d3f2 
# Conflicts:
#	application/src/ext-test/java/org/opentripplanner/ext/stopconsolidation/DecorateConsolidatedStopNamesTest.java
#	application/src/test/java/org/opentripplanner/model/TimetableSnapshotTest.java
@vpaturet vpaturet force-pushed the rename_repositories branch from b6ec12f to 7571816 Compare October 16, 2024 09:24
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
@vpaturet vpaturet merged commit 1e3ffe0 into opentripplanner:dev-2.x Oct 16, 2024
5 checks passed
@vpaturet vpaturet deleted the rename_repositories branch October 16, 2024 13:02
t2gran pushed a commit that referenced this pull request Oct 16, 2024
Add changelog entry for #6148 [ci skip]
ffe45b3
t2gran pushed a commit that referenced this pull request Oct 16, 2024
Bump serialization version id for #6148
fd2124e
@vpaturet vpaturet mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t2gran t2gran t2gran approved these changes

@leonardehrenfried leonardehrenfried leonardehrenfried approved these changes

Assignees

@vpaturet vpaturet

Labels
bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Technical Debt
Projects
None yet
Milestone
2.7 (next release)
Development

Successfully merging this pull request may close these issues.
3 participants
@vpaturet @leonardehrenfried @t2gran